Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix tests and ignore failed transfers if already executed #238

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

tcar121293
Copy link
Contributor

@tcar121293 tcar121293 commented Dec 19, 2024

Description

  • if failedExecution comes after the transfer is successfully executed, just ignore that event
  • added edge case fix - always upsert deposit, if updating transfer, don't update the status

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@tcar121293 tcar121293 marked this pull request as ready for review December 20, 2024 09:51
@tcar121293 tcar121293 merged commit 293133a into main Dec 20, 2024
5 checks passed
@tcar121293 tcar121293 deleted the tcar/ignore-failed-transfers branch December 20, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants