fix: EVM message handling refactor #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj52951
changed the title
mj52951
requested review from
P1sar,
mpetrun5,
tcar121293,
MakMuftic,
nmlinaric and
freddyli7
as code owners
mpetrun5
requested changes
Jan 5, 2024
added 2 commits
January 5, 2024 14:25
mpetrun5
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created the
Transfermessage type and made EVM message handling more generalized.The issues partially addressed by this pull request are #234 and #232. Additionally, the same changes need to be implemented on Substrate message handling, for which a new pull request will be opened.
Note: e2e, unit and lint tests should fail as this is a step-by-step refactor focusing on smaller parts that should work