Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert with custom error for 0 conversion amounts #36

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

nmlinaric
Copy link

Description

If conversion amount from source chain to Bridge internal decimals (18) would result in 0 converted amount, revert with custom error DepositAmountTooSmall

How Has This Been Tested? Testing details.

unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in Sygma-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@nmlinaric nmlinaric force-pushed the nmlinaric/audit/conversion-fix branch from 3fd1c56 to c598043 Compare March 11, 2024 15:47
@nmlinaric nmlinaric merged commit cb2d7ae into master Mar 13, 2024
3 checks passed
@nmlinaric nmlinaric deleted the nmlinaric/audit/conversion-fix branch March 13, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants