Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add zero address constructor checks #39

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

nmlinaric
Copy link

Description

Adds zero address constructor checks

How Has This Been Tested? Testing details.

unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in Sygma-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@nmlinaric nmlinaric force-pushed the nmlinaric/zero-address-check branch from a8c2525 to cf41aaf Compare March 12, 2024 13:02
src/contracts/Executor.sol Outdated Show resolved Hide resolved
src/contracts/Router.sol Outdated Show resolved Hide resolved
src/contracts/Bridge.sol Outdated Show resolved Hide resolved
@nmlinaric nmlinaric force-pushed the nmlinaric/zero-address-check branch from 2fd81b9 to 2493f35 Compare March 13, 2024 13:36
@nmlinaric nmlinaric requested a review from lastperson March 13, 2024 13:47
@nmlinaric nmlinaric merged commit e6b5cf8 into master Mar 15, 2024
3 checks passed
@nmlinaric nmlinaric deleted the nmlinaric/zero-address-check branch March 15, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants