Linting

spruceid · Dec 6, 2024 · 0ae09b6 · 0ae09b6
1 parent 8085446
commit 0ae09b6
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 11 deletions.
diff --git a/src/cose/mac0.rs b/src/cose/mac0.rs
@@ -218,8 +218,6 @@ mod hmac {
 
     use super::super::SignatureAlgorithm;
 
-    /// Implement [`SignatureAlgorithm`].
-
     impl SignatureAlgorithm for Hmac<Sha256> {
         fn algorithm(&self) -> iana::Algorithm {
             iana::Algorithm::HMAC_256_256

diff --git a/src/cose/serialized_as_cbor_value.rs b/src/cose/serialized_as_cbor_value.rs
@@ -5,7 +5,7 @@ use serde::{Deserialize, Serialize};
 /// implement `Serialize`/`Deserialize` but only `AsCborValue`.
 pub struct SerializedAsCborValue<T>(pub T);
 
-impl<'a, T: Clone + AsCborValue> Serialize for SerializedAsCborValue<&'a T> {
+impl<T: Clone + AsCborValue> Serialize for SerializedAsCborValue<&T> {
     fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
     where
         S: serde::Serializer,

diff --git a/src/cose/sign1.rs b/src/cose/sign1.rs
@@ -231,8 +231,6 @@ mod p256 {
 
     use crate::cose::SignatureAlgorithm;
 
-    /// Implement [`SignatureAlgorithm`].
-
     impl SignatureAlgorithm for SigningKey {
         fn algorithm(&self) -> iana::Algorithm {
             iana::Algorithm::ES256
@@ -252,8 +250,6 @@ mod p384 {
 
     use crate::cose::SignatureAlgorithm;
 
-    /// Implement [`SignatureAlgorithm`].
-
     impl SignatureAlgorithm for SigningKey {
         fn algorithm(&self) -> iana::Algorithm {
             iana::Algorithm::ES384

diff --git a/src/definitions/device_request.rs b/src/definitions/device_request.rs
@@ -17,7 +17,6 @@ pub type ReaderAuth = MaybeTagged<CoseSign1>;
 /// Represents a device request.
 #[derive(Clone, Debug, Serialize, Deserialize)]
 #[serde(rename_all = "camelCase")]
-
 pub struct DeviceRequest {
     /// The version of the device request.
     pub version: String,

diff --git a/src/definitions/x509/extensions.rs b/src/definitions/x509/extensions.rs
@@ -223,7 +223,7 @@ pub fn validate_signer_key_usage(bytes: Vec<u8>) -> Vec<Error> {
 but no other key usages are allowed */
 pub fn validate_root_key_usage(bytes: &[u8]) -> Vec<Error> {
     let mut errors = vec![];
-    let key_usage = KeyUsage::from_der(&bytes);
+    let key_usage = KeyUsage::from_der(bytes);
     match key_usage {
         Ok(ku) => {
             if !ku.crl_sign() {
@@ -328,7 +328,7 @@ pub fn validate_basic_constraints(bytes: Vec<u8>) -> Vec<Error> {
     let basic_constraints = BasicConstraints::from_der(&bytes);
     match basic_constraints {
         Ok(bc) => {
-            if !bc.path_len_constraint.is_some_and(|path_len| path_len == 0) && bc.ca {
+            if bc.path_len_constraint.is_none_or(|path_len| path_len != 0) && bc.ca {
                 return vec![Error::ValidationError(format!(
                     "Basic constraints expected to be CA:true, path_len:0, but found: {:?}",
                     bc

diff --git a/tests/common.rs b/tests/common.rs
@@ -108,7 +108,7 @@ impl Device {
         )]
         .into_iter()
         .collect();
-        session_manager.prepare_response(&requested_items, permitted_items);
+        session_manager.prepare_response(requested_items, permitted_items);
         let (_, sign_payload) = session_manager.get_next_signature_payload().unwrap();
         let signature: p256::ecdsa::Signature = key.sign(sign_payload);
         session_manager