-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FRW-8409 Added sales order and order item state history #22
FRW-8409 Added sales order and order item state history #22
Conversation
export const options = loadDefaultOptions(); | ||
|
||
let metrics = new Metrics([{ | ||
key: 'company-users-create', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the metric key must be corrected otherwise you won't be able to see the correct results in the summary
console.error(response.body) | ||
} | ||
|
||
metrics.add('sales-order-item-state-update', requestHandler.getLastResponse(), 200); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to use this key sales-order-item-state-update you have to define it as a metric at line 12.
The general point is metrics object must be created before test execution and then you can use them. In this case metric will be just ignored as it was not defined initially.
This is walid for all your tests
tests/dex/tests/post/companyUser.js
Outdated
} | ||
} | ||
|
||
options.thresholds = metrics.getThresholds(); | ||
|
||
const payloadSize = 200; | ||
const payloadSize = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A size of 1 is good for debugging but for test in general it is not the best sizing. We have to find limits and provide our recommendations
iterations: 250, | ||
vus: 5 | ||
iterations: 1, | ||
vus: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here the same - I think this is debugging configuration
export const options = loadDefaultOptions(); | ||
|
||
let metrics = new Metrics([{ | ||
key: 'sales-order-create', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix metric key
- Added test runner - Extended readme file
8d1d72f
into
feature/frw-8409/dex-adjust-loadtesting
Ticket: https://spryker.atlassian.net/browse/FRW-8409