Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to set up a custom Xdebug host IP #255

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

peresypkin
Copy link
Contributor

@peresypkin peresypkin commented Nov 3, 2021

Description

  • The PR adds the ability to set up a custom Xdebug host IP for the case when
    Docker is deployed inside a virtual machine (e.g. Vagrant + VirtualBox)
    for local development.

Change log

  • SPRYKER_CUSTOM_XDEBUG_HOST_IP variable has been added to generator/src/templates/deploy.bash.twig. Its value gets set in the deployment configuration as follows:
docker:
    ...
    debug:
        enabled: true
        xdebug:
            enabled: true
            custom_host_ip: 192.168.56.1
    ...
  • SPRYKER_XDEBUG_HOST_IP variable is set based on the value of SPRYKER_CUSTOM_XDEBUG_HOST_IP. If it's not defined, the default logic to get the IP of the host is used.

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@peresypkin peresypkin force-pushed the custom-xdebug-host-ip branch 2 times, most recently from 6a7c260 to 4341d2d Compare February 4, 2022 09:20
@peresypkin peresypkin force-pushed the custom-xdebug-host-ip branch from 4341d2d to 2cc5c58 Compare March 8, 2022 14:08
@ilstefano
Copy link

ilstefano commented Mar 13, 2022

Hi all,

this feature is also needed when remote debugging in a container, as I'm used to do it with VSC (Visual Studio Code).

Currently I workaround by manually setting SPRYKER_XDEBUG_HOST_IP=localhost in each projects' deploy-file.

Thank you for this code contribution!

Stephan

@peresypkin peresypkin force-pushed the custom-xdebug-host-ip branch from 2cc5c58 to af9b1e6 Compare March 18, 2022 09:52
@peresypkin peresypkin force-pushed the custom-xdebug-host-ip branch from af9b1e6 to 8709ca9 Compare March 29, 2022 08:16
@ilstephano
Copy link
Contributor

Hi @alexanderM91 and @sprymiker,

this faeture is quite usefull for us in my company.
Are you going to release it?

Thank you,
Stephan

@peresypkin peresypkin force-pushed the custom-xdebug-host-ip branch from 8709ca9 to 3129dd2 Compare May 3, 2022 08:09
@peresypkin peresypkin force-pushed the custom-xdebug-host-ip branch from 3129dd2 to f1ede98 Compare May 14, 2022 15:21
@peresypkin peresypkin force-pushed the custom-xdebug-host-ip branch from f1ede98 to 66c8b46 Compare May 30, 2022 03:30
@peresypkin peresypkin force-pushed the custom-xdebug-host-ip branch from cfa7421 to 239915b Compare June 13, 2022 09:25
@peresypkin peresypkin force-pushed the custom-xdebug-host-ip branch from 239915b to 5a2fae6 Compare July 15, 2022 09:10
@peresypkin peresypkin force-pushed the custom-xdebug-host-ip branch from 5a2fae6 to d296594 Compare July 27, 2022 08:13
* Add the ability to set up a custom Xdebug host IP for the case when
Docker is deployed inside a virtual machine (e.g. Vagrant + VirtualBox)
for local development.
@peresypkin peresypkin force-pushed the custom-xdebug-host-ip branch from d296594 to 13deb2f Compare August 12, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants