Feature/nginx stub module SCO-154254 #475
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any blockers to merge it @ls-spryker @alexanderM91 ? |
oleg-glushak
approved these changes
Mar 18, 2024
|
ping @alexanderM91 @ls-spryker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This proposal is to add nginx stub module to enable status reporting.
It is a part of [SRE O11y observability project]
(https://spryker.atlassian.net/wiki/spaces/SCOS/pages/3934913114/O11Y+NextGen+Solution+Architecture).
Rationale behind is that we intend to collect nginx stats from frontend containers used by our customers.
Current solution work as long as the frontend image which is built by docker-sdk for each customer is using the image ENTRYPOINT set to /entrypoint.sh here and the entrypoint.sh itself executes anything with put to the image COMMAND as specified here. If any of these changes in the docker-sdk some way, our COMMAND rewrite can start breaking the frontend container completely. And since we keep this change outside of docker-sdk, it's quite easy to overlook it during docker-sdk development process.
Setting the stub module on as default by enabling it on docker-sdk solves above problem.
Related resources
https://github.com/spryker-projects/sre-services/pull/74/#discussion_r1427641574
Change log
Enabled nginx stub module. The ngx_http_stub_status_module module provides access to basic status information.
By default status is reachable via http://localhost/nginx_status
Checklist