Single dialect import #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't just re-export all, as that will easily lead to unwanted exports, like the export of formatters map, which should not have been publicly exposed.
Also add comment to avoid removing this syntax in the future
inferrinizzard
approved these changes
Nov 4, 2022
| export * from './allDialects.js'; | ||
|
|
||
| // NB! To re-export types the "export type" syntax is required by webpack. | ||
| // Otherwise webpack build will fail. |
There was a problem hiding this comment.
there's an eslint-typescript rule here we can leverage, use-consistent-type-exports
There was a problem hiding this comment.
I can make a PR to update eslint rules soon
There was a problem hiding this comment.
Good find. I added the rule on my own. Seems to work just as needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New API for supporting import of a single dialect. As discussed in #484, I've added a separate formatting function that works a bit differently than the old one.
The old
format()function works like before, with the exception thatlanguageparameter can only be string:The new
formatDialect()only works with explicitly imported dialect:formatDialect()is also used under the hood by the oldformat()function.I chose to name it
formatDialectto make it clear that it accepts adialectconfig option (instead oflanguage). This also aligns with the naming of types, where the actual value is aDialectOptionsobject. (Originally I thought of usinglanguageoption for both, but this seemed too confusing - an option expecting one type in one context and another type in another context - so I opted for clearly distinct option names).Fixes #452