Add DROP IDENTITY, OVERRIDING SYSTEM VALUE to PostgreSQL clauses

[karlhorky]

Hey @nene, hope you're great! 👋 Happy New Year!

Quick PR to recognize DROP IDENTITY and OVERRIDING SYSTEM VALUE as one-line clauses

With the configuration:

{
  keywordCase: 'upper',
  identifierCase: 'lower',
  dataTypeCase: 'lower',
  functionCase: 'lower',
}

This makes the following change:

DROP IDENTITY

-- Before PR #820
ALTER TABLE events
ALTER COLUMN id
DROP identity;

-- After PR #820
ALTER TABLE events
ALTER COLUMN id
DROP IDENTITY;

OVERRIDING SYSTEM VALUE

-- Before PR #820
INSERT INTO
  events (
    id,
    title,
    description
  ) overriding system value
VALUES
  (
    1,
    'abc',
    'def'
  );

-- After PR #820
INSERT INTO
  events (
    id,
    title,
    description
  )
OVERRIDING SYSTEM VALUE
VALUES
  (
    1,
    'abc',
    'def'
  );

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[nene]

Thanks. This is useful.

However I should point out that using identifierCase: lower is really just asking for trouble. See the docs for clarification. There's a reason this configuration option is marked as experimental.

[karlhorky]

Thanks for the review and merge!

Interesting, I see that the commit f4cda21 adding this explanation was motivated by #809 (hi again @gajus 👋)

Personally, I want this behavior - everything by default lowercase, and then the recognized keywords as uppercase. As such, I would personally evaluate each of these cases as (minor) bugs in SQL Formatter's dialects and keyword detection.

Opened a new PR for these particular cases mentioned by @gajus:

• Add more PostgreSQL keywords and phrases #821

[karlhorky]

Thanks also for the release in [email protected], can confirm it's working 👍