Add methods to fix/unfix the view's dimens for use in dialogs #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Fix the layout height/width after the dialog has been shown. | ||
| getLayoutParams().height = getMeasuredHeight(); | ||
| getLayoutParams().width = getMeasuredWidth(); | ||
| // Post this runnable so it runs _after_ the dimen changes have been applied/re-measured. |
There was a problem hiding this comment.
Is re-measuring guaranteed here? You aren't doing anything to trigger a layout. Or are you assuming the initial layout pass hasn't happened yet?
There was a problem hiding this comment.
Ah, nevermind. I get it. You're changing the params to be fixed at the measured size.
|
I feel dirty just reading this PR. |
JakeWharton
added a commit
that referenced
this pull request
Jan 8, 2014
Add methods to fix/unfix the view's dimens for use in dialogs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JakeWharton this is pretty ugly but I couldn't figure out any other way to keep the dialog from resizing (#65).
I suspect this may also address dialog perf issues (#26) but haven't confirmed that yet.