PHPCS 4.x | File::isReference(): simplify code #3338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 08824f3 added support for `T_USE` tokens for closures being parentheses owners. As the `File::getMethodParameters()` method also supports closure `use` parameters already, the code in the `File::isReference()` method can now be simplified. The existing unit tests already cover this.
jrfnl
force-pushed
the
phpcs-4.x/file-isreference-simplify
branch
from
92bd8c9 to
8765771
Compare
|
Closing as replaced by PHPCSStandards/PHP_CodeSniffer#43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 08824f3 added support for
T_USEtokens for closures being parentheses owners and PR #3104 fixed this up for non-closure use.As the
File::getMethodParameters()method also supports closureuseparameters already, the code in theFile::isReference()method can now be simplified.The existing unit tests already cover this.