Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ai iterate code cell #144

Merged
merged 8 commits into from
Jul 19, 2024
Merged

Ai iterate code cell #144

merged 8 commits into from
Jul 19, 2024

Conversation

nichochar
Copy link
Contributor

Diff based experience with unified view and accept / reject mechanics

CleanShot.2024-07-19.at.13.58.11.mp4

@nichochar nichochar requested a review from benjreinhart July 19, 2024 21:00
packages/shared/src/schemas/websockets.ts Outdated Show resolved Hide resolved
@@ -50,6 +56,11 @@ export const CellUpdatedPayloadSchema = z.object({
cell: CellSchema,
});

export const CellAiGeneratedPayloadSchema = z.object({
cellId: z.string(),
output: z.string(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can we name this source to match the name of this property on cell? It is the source we're getting back here, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source felt a little wrong to me, it's LLM output, not really a code source.

@nichochar nichochar merged commit 97d59c0 into main Jul 19, 2024
1 check passed
@nichochar nichochar deleted the ai-iterate-code-cell branch July 19, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants