refactor: use feedback string column #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sripwoud
force-pushed
the
feat/freetext-feedback
branch
from
d540d93
to
e777745
Compare
sripwoud
changed the title
sripwoud
force-pushed
the
feat/freetext-feedback
branch
from
c8a1147
to
627e50b
Compare
sripwoud
changed the title
sripwoud
force-pushed
the
feat/freetext-feedback
branch
from
f28b454
to
971a478
Compare
sripwoud
force-pushed
the
feat/freetext-feedback
branch
from
971a478
to
4142bd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards supporting multiple types of questions.
This changes the type of the
feedbackcolumn of thefeedbackstable totextso that it is future proof.It would be too complex (impossible?) to check constraints between feedback value and corresponding question type on each inserts (e.g we can only insert yes/no text feedback for a boolean question type). So this is done at the application layer within the feedbacks service with a dynamic schema.