-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak sphere rew #5
Draft
Yasu31
wants to merge
23
commits into
main
Choose a base branch
from
tweak_sphere_rew
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed objects in the scene)
…can be edited in child class - remove the goal_init_states variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: merge only after I fix the todo in #4
The implementation of the sphere rotation reward had a “bug” in it… it’s a different shape based on the direction of rotation, when the direction is -1 it doesn’t decrease when the velocity magnitude is larger than 2 rad/s
Maybe that is why the -1 direction trained much better, thanks to this unintended bug, I’m retraining +1 direction with the same reward profile to see if it’s better
This reward seems to work more consistently and use each finger equally for the +1 direction, than for the original reward (for the -1 direction, the implementation remains exactly the same
checklist
PR can be merged after all these are met