Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test restarting client after getting excluded #101

Merged
merged 11 commits into from
May 4, 2023
Merged

Conversation

Powersource
Copy link
Collaborator

Fixes #90

@socket-security
Copy link

socket-security bot commented Apr 27, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Deprecated license ✅ 0 issues
Missing license ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
[email protected] 6.2.0...7.0.0 None +0/-0

@Powersource Powersource marked this pull request as ready for review May 3, 2023 12:08
@Powersource Powersource requested a review from mixmix May 3, 2023 12:13
Comment on lines +619 to +624
name: 'bobrestart',
keys: ssbKeys.generate(null, 'bob'),
mfSeed: Buffer.from(
'0000000000000000000000000000000000000000000000000000000000000b0b',
'hex'
),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think extract these as bobConfig and then re-use it below (with { rimraf: false, ...bobConfig }

@mixmix
Copy link
Member

mixmix commented May 4, 2023

I love reading nice clear tests.

I don't know what your code changed that means it behaves differently, but it's passing tests so 👍 ❤️ 🐴

@Powersource
Copy link
Collaborator Author

the big/only change is in box2/keyring, where we now keep the readKeys and root. we do that because we ran into a bug when adding these tests (specifically when the client was start()ing back up again. the last few tests for list() etc are just for stability/sanity checking, i thought they might be failing but they weren't, so that's nice

@Powersource Powersource merged commit 18cff8a into master May 4, 2023
@Powersource Powersource deleted the restart-test branch May 4, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test restarting client after getting excluded. Will we try to rejoin old epochs?
2 participants