-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test restarting client after getting excluded #101
Conversation
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
name: 'bobrestart', | ||
keys: ssbKeys.generate(null, 'bob'), | ||
mfSeed: Buffer.from( | ||
'0000000000000000000000000000000000000000000000000000000000000b0b', | ||
'hex' | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think extract these as bobConfig
and then re-use it below (with { rimraf: false, ...bobConfig }
I love reading nice clear tests. I don't know what your code changed that means it behaves differently, but it's passing tests so 👍 ❤️ 🐴 |
the big/only change is in box2/keyring, where we now keep the readKeys and root. we do that because we ran into a bug when adding these tests (specifically when the client was start()ing back up again. the last few tests for list() etc are just for stability/sanity checking, i thought they might be failing but they weren't, so that's nice |
Fixes #90