Publish re-ad messages on the additions feed #85
Conversation
arj03
changed the title
|
@arj03 no it's re-add, not read :P |
| const excludeOpts = { | ||
| tangles: ['members'], | ||
| isValid: isExclude, | ||
| } |
There was a problem hiding this comment.
I think we need to think about where we want the exclude published... (which feed).
I have a feeling it should be in the same feed as the additions... but I can't quite justify.
I think it's that we want to be sure we have all the messages for each epoch membership stuff and sprinkling the around might lead to funny edge cases?
what do you think?
There was a problem hiding this comment.
i don't mind having it in the epochs. the main purpose of the additions feed is that people who are not in a group know where to look for stuff that is DMed to them
There was a problem hiding this comment.
ideally i want re-additions also in the epochs, i think we're mostly moving them to the additions for lack of time
| const msgsFromAdditions = await alice.db.query( | ||
| where(author(aliceAdditions.id)), | ||
| toPromise() | ||
| ) |
There was a problem hiding this comment.
🍍 it's cool seeing different ways of querying around the space + testing. I would have got a different way but this is tidy (looking within a particular sub-feed).
db.query is so sweet
staltz
changed the title
for #79 Hopefully fixes it, but we need to verify in #78
tests were passing before the first commit