Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate docs bugs #77

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

alaincormier-ssc
Copy link
Contributor

@alaincormier-ssc alaincormier-ssc commented Mar 13, 2024

inventory-controls.py error when parsing YAML resource in comment

Traceback (most recent call last):
  File "...myrepo/tools/scripts/kpt/../common/inventory-controls.py", line 55, in <module>
    resource_name = data['metadata']['name']
TypeError: 'NoneType' object is not subscriptable
Script terminating unexpectedly with exit code: 1

fix: add test to only process valid resources

generate-docs.sh error when running kpt docs with a Kptfile containing mutators selectors

[FAIL] "gcr.io/kpt-fn/generate-kpt-pkg-docs:unstable" in 700ms
  Results:
    [error]: failed to generate doc: failed to decode Kptfile: invalid 'v1' Kptfile: yaml: unmarshal errors:   line 41: field selectors not found in type v1.Function
  Stderr:
    "failed to decode Kptfile: invalid 'v1' Kptfile: yaml: unmarshal errors:"
    "  line 41: field selectors not found in type v1.Function"
  Exit code: 1

Script terminating unexpectedly with exit code: 1

fix: remove the 'selectors' before running the function in the temp directory

Copy link
Contributor

@lucstjean-ssc lucstjean-ssc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@anoopsidhu-ssc anoopsidhu-ssc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anoopsidhu-ssc anoopsidhu-ssc merged commit b162488 into main Mar 13, 2024
1 check passed
@anoopsidhu-ssc anoopsidhu-ssc deleted the az9360-9321-generate-docs-bugs branch March 13, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants