Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fixed age intervals #194

Closed
wants to merge 25 commits into from
Closed

Conversation

MaHaWo
Copy link
Collaborator

@MaHaWo MaHaWo commented Nov 28, 2024

first version (obsolete)

  • done in preparation to the statistics computation things in the feedback backend
  • no fixed milestone timedelta anymore (that we had set to 6 months), but a configurable interval per milestone
  • backend endpoints for adding, removing and modifying age intervals
    • I'm not entirely sure if allowing modification is a good idea as it will invalidate previous analysis/feedbacks
  • milestones have an new ageinterval member that tells to which interval they belong.
    • there would be the possibility to compute this interval automatically if the data is good enough, but I'm not sure we can do this reliably, and would prefer if they would do that on their side of things and then just put in the numbers instead of giving us some algorithm for it that we have to implement and maintain and be responsible for
  • new tab in admin frontend interface for the age intervals
  • new element in the milestone frontend to select it.
  • adjusted the database query that pulls out the relevant answers for the milestoneanswersession based on time.
  • vast majority of the indicated changes come from the regenerated openapi.json file.

revised version

  • new elements expected_age_months_minus and expected_age_months_plus in milestone database models.
  • these are relative to expected_age_months
  • adjusted the database query that pulls out the relevant answers for the milestoneanswersession based on time.
  • age interval for a milestone = [expected_age_months-expected_age_months_minus, expected_age_months + expected_age_months_plus]
  • add three-way range slider frontend component and replace the slider for expected_age_months in EditMiletoneModal with that to edit the age interval for a milestone in one go.
    • styling was surprisingly difficult to get consistent between firefox and chromium, and it's still a bit off :(

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 10.52632% with 68 lines in your changes missing coverage. Please review.

Project coverage is 29.71%. Comparing base (78c1a9e) to head (236639c).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...src/lib/components/Admin/EditMilestoneModal.svelte 0.00% 32 Missing ⚠️
...nd/src/lib/components/DataInput/RangeSlider.svelte 0.00% 24 Missing and 1 partial ⚠️
frontend/src/lib/components/MilestoneGroup.svelte 0.00% 9 Missing ⚠️
...nd/src/lib/components/Admin/MilestoneGroups.svelte 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
- Coverage   30.16%   29.71%   -0.46%     
==========================================
  Files         103      106       +3     
  Lines        3388     3507     +119     
  Branches       91       94       +3     
==========================================
+ Hits         1022     1042      +20     
- Misses       2290     2386      +96     
- Partials       76       79       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaHaWo MaHaWo requested a review from lkeegan November 29, 2024 15:17
@MaHaWo MaHaWo self-assigned this Dec 10, 2024
@MaHaWo
Copy link
Collaborator Author

MaHaWo commented Dec 18, 2024

@lkeegan will we use this thing now or should it be closed (will keep the branch around locally though in that case)

@lkeegan
Copy link
Member

lkeegan commented Dec 18, 2024

I guess it's all implemented in other PRs by now? So yes, let's close the PR but keep the branch in case

@lkeegan lkeegan closed this Dec 18, 2024
@MaHaWo
Copy link
Collaborator Author

MaHaWo commented Dec 19, 2024

no, it's not. in fact, I went to some lengths to not pollute other PRs with this....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants