Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add included_in_statistics flag to answersession #215

Merged
merged 12 commits into from
Jan 13, 2025

Conversation

MaHaWo
Copy link
Collaborator

@MaHaWo MaHaWo commented Dec 18, 2024

  • add flags to MilestoneAnswer(Public) that say whether an answer has been used in a milestone or milestonegroup statistics already.
  • adjust fixtures to use these
  • add new tests to for correct usage of the flags

fixes #204

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.16%. Comparing base (5d818cf) to head (c30cf7d).

Additional details and impacted files
@@            Coverage Diff             @@
##            main     #215       +/-   ##
==========================================
+ Coverage   1.36%   32.16%   +30.79%     
==========================================
  Files         87      114       +27     
  Lines       2787     4160     +1373     
  Branches      99       99               
==========================================
+ Hits          38     1338     +1300     
- Misses      2665     2738       +73     
  Partials      84       84               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaHaWo MaHaWo changed the title Add included in statistics flat to answersession Add included_in_statistics flag to answersession Dec 18, 2024
@MaHaWo MaHaWo requested a review from lkeegan December 20, 2024 07:56
@MaHaWo MaHaWo self-assigned this Dec 20, 2024
Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - one minor comment

Copy link

@MaHaWo MaHaWo merged commit 8acd15e into main Jan 13, 2025
8 checks passed
@MaHaWo MaHaWo deleted the add-included_in_statistics-flat-to-answersession branch January 13, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a boolean included_in_statistics flag to MilestoneAnswerSession
3 participants