-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate client suggestions for feedback page #222
Incorporate client suggestions for feedback page #222
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
==========================================
- Coverage 30.30% 29.76% -0.55%
==========================================
Files 115 115
Lines 4421 4502 +81
Branches 100 100
==========================================
Hits 1340 1340
- Misses 2997 3078 +81
Partials 84 84 ☔ View full report in Codecov by Sentry. |
sorry. review request was early. |
have you had a look at the |
The best way imo would be for you to run the whole thing locally - this should be fairly straightforward to do using docker: https://github.com/ssciwr/mondey/blob/main/DEVELOPMENT.md#run-locally-with-docker Then you can sign-up as a user on your local version of the website, and whenever you want to see what a branch looks like you can checkout the branch and re-build the docker containers. If this isn't an option, then an alternative would be for us to merge these changes, update the running deployed website, then you can try it out there and make a new issue if you have any suggestions or changes. (A third option here will be for you to run the frontend ui tests for this, but they don't exist yet - still on our todo list..) |
…page - update to use new i18n functionality
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - I merged main and updated all the i18n related stuff, @MaHaWo maybe you could check that I didn't break anything in the process?
@lkeegan Thanks for the info. I tried to run the test with playwright, but there was no feedback page, just the main page and registration. You can merge this, but I still try to run it through docker to be able to check for new changes in the future. |
Done: