Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement upload of results #46

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Implement upload of results #46

merged 1 commit into from
Oct 28, 2024

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Oct 28, 2024

  • runner creates three folders where the script runs, and uploads their contents as zipfiles:
    • /user_results: provided to user
    • /trusted_user_results: provided to user if they have "full results" enabled by an admin
    • /admin_results: only visible to admins
  • admin results are always uploaded, included for failed runs (for debugging)
  • user results are only provided if the run was successful
  • add PREDICTCR_RUNNER_SCRIPT_DIR env var to docker compose to specify where script & model can be found
  • add /admin/result endpoint to download admin results zipfile
  • switch from micromamba to miniconda docker image
    • reticulate doesn't seem to support micromamba, at least within docker
  • re-enable runner docker image CI
  • update runner README.md
  • resolves results upload #6
  • resolves return error message if run fails #43

Also refactor admin views using tabs

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 64.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 77.88%. Comparing base (4838031) to head (844151e).

Files with missing lines Patch % Lines
backend/src/predicTCR_server/app.py 42.85% 16 Missing ⚠️
backend/src/predicTCR_server/model.py 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   78.82%   77.88%   -0.94%     
==========================================
  Files           8        8              
  Lines         680      710      +30     
==========================================
+ Hits          536      553      +17     
- Misses        144      157      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkeegan lkeegan force-pushed the refactor_admin_view branch from c89c528 to 2e48216 Compare October 28, 2024 14:24
- runner creates three folders where the script runs, and uploads their contents as zipfiles:
  - `/user_results`: provided to user
  - `/trusted_user_results`: provided to user if they have "full results" enabled by an admin
  - `/admin_results`: only visible to admins
- admin results are always uploaded, included for failed runs (for debugging)
- user results are only provided if the run was successful
- add `PREDICTCR_RUNNER_SCRIPT_DIR` env var to docker compose to specify where script & model can be found
- add /admin/result endpoint to download admin results zipfile
- switch from micromamba to miniconda docker image
  - reticulate doesn't seem to support micromamba, at least within docker
- re-enable runner docker image CI
- update runner README.md
- resolves #6
- resolves #43

Also refactor admin views using tabs
@lkeegan lkeegan force-pushed the refactor_admin_view branch from 2e48216 to 844151e Compare October 28, 2024 14:51
@lkeegan lkeegan merged commit b8b797b into main Oct 28, 2024
5 checks passed
@lkeegan lkeegan deleted the refactor_admin_view branch October 28, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

return error message if run fails results upload
2 participants