wip: notation implementation #1885
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phbelitz
force-pushed
the
feat/notation
branch
from
b483276 to
ccdd4f5
Compare
phbelitz
force-pushed
the
feat/notation
branch
from
b9e7a27 to
cc68f82
Compare
Starkteetje
reviewed
Jan 24, 2025
| # simple test cases for notation | ||
| - id: unsigned | ||
| txt: Testing unsigned image... | ||
| ref: ghcr.io/sse-secure-systems/testimage:notation-unsign |
There was a problem hiding this comment.
Suggested change
| ref: ghcr.io/sse-secure-systems/testimage:notation-unsign | |
| ref: ghcr.io/sse-secure-systems/testimage:notation-unsigned |
| expected_msg: error during notation validation | ||
| - id: signed | ||
| txt: Testing signed image... | ||
| ref: ghcr.io/sse-secure-systems/testimage:notation-sign |
There was a problem hiding this comment.
Suggested change
| ref: ghcr.io/sse-secure-systems/testimage:notation-sign | |
| ref: ghcr.io/sse-secure-systems/testimage:notation-signed |
| install "make" | ||
| multi_test "notation/cases.yaml" | ||
| uninstall "make" | ||
| } |
| type InMemoryTrustStore struct { | ||
| trustRoots []auth.TrustRoot | ||
| certs map[string][]*x509.Certificate | ||
| truststore.X509TrustStore |
There was a problem hiding this comment.
Where is this used, isn't the interface already satisfied?
Comment on lines
+130
to
+132
| SignatureVerification: trustpolicy.SignatureVerification{ | ||
| VerificationLevel: trustpolicy.LevelStrict.Name, | ||
| }, |
There was a problem hiding this comment.
What about VerifyTimestamp? Without having looked at it this looks like something we want to have an opinion on
| VerificationLevel: trustpolicy.LevelStrict.Name, | ||
| }, | ||
| TrustStores: utils.Map(trs, func(tr auth.TrustRoot) string { return fmt.Sprintf("ca:%s", tr.Name) }), | ||
| TrustedIdentities: []string{"*"}, |
There was a problem hiding this comment.
Without knowing anything, this looks weird 🤔
Comment on lines
+12
to
+14
| func TestNewInMemoryTrustStore(t *testing.T) { | ||
| // already tested in notation_validator_test.go | ||
| } |
There was a problem hiding this comment.
Why have this test case here then?
| []string{}, | ||
| "no trust roots provided for validator", | ||
| }, | ||
| { // 3: unmarschal error |
There was a problem hiding this comment.
Suggested change
| { // 3: unmarschal error | |
| { // 3: unmarshal error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for notation
Checklist
developChart.yaml(if necessary)