Update and improve handling of projections and area definitions #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnaVukasinovic
force-pushed
the
gmv_issue_393
branch
from
c24ff10 to
3871bb3
Compare
…rea definitions; unit testing still pending
AnaVukasinovic
force-pushed
the
gmv_issue_393
branch
from
3871bb3 to
f7ffc9d
Compare
RudiLauster
approved these changes
Feb 5, 2025
RudiLauster
reviewed
Feb 5, 2025
uwsift/etc/SIFT/config/logging.yaml
Outdated
There was a problem hiding this comment.
Yes, I guess it's a good idea to set back to "INFO".
Andrea @ameraner , what do you think?
There was a problem hiding this comment.
tbh I'd rather leave it do DEBUG, since it's then easier, in case of errors, to request the full log from a user without having him/her to modify the user settings first.
RudiLauster
approved these changes
Feb 5, 2025
ameraner
approved these changes
Feb 25, 2025
uwsift/etc/SIFT/config/logging.yaml
Outdated
There was a problem hiding this comment.
tbh I'd rather leave it do DEBUG, since it's then easier, in case of errors, to request the full log from a user without having him/her to modify the user settings first.
ameraner
changed the title
…rea definitions; unit testing still pending
Added unit test for checking that the resampling is done when set up
RudiLauster
force-pushed
the
gmv_issue_393
branch
from
bd6a015 to
706c871
Compare
ameraner
requested changes
Feb 27, 2025
ameraner
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve this issue, a configuration change was required in the area_definitions.yaml file. The GUI was modified, along with the logic for applying resolution in the Open File Wizard window. Additionally, users are now able to select a custom resolution.