Define texture internalformat to fix colormap discretisation #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RudiLauster
force-pushed
the
gmv_issue_404
branch
from
e4749cc to
11f43bb
Compare
passing on eventual texture_kwargs in the _init_texture method Co-authored-by: Andrea Meraner <[email protected]>
ameraner
changed the title
ameraner
reviewed
Feb 27, 2025
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
ameraner
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug occurred because the "internalFormat" field of the data texture was left as None. The bug appeared in the SIMPLE_GEOLOCATED and PIXEL_MATRIX ImageDisplayMode. It was fixed by overriding the Image class, where the _init_texture method was overridden to set the "internalFormat" parameter to "r32f"