Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save_kdbx4: Fix write corruption for large Databases #218

Merged
merged 2 commits into from
Apr 28, 2024
Merged

save_kdbx4: Fix write corruption for large Databases #218

merged 2 commits into from
Apr 28, 2024

Conversation

baranyildirim
Copy link
Contributor

@baranyildirim baranyildirim commented Apr 13, 2024 •
edited by sseemayer
Loading

In this PR:

  • Add test that writes and reads back a large database (100000). This exposes the issue with write corruption, which is not detected by other tests.
  • Fix write corruption by removing chunking behavior.
  • The tests fail on master, but pass after the chunking is removed.

Closes #219

@baranyildirim baranyildirim mentioned this pull request Apr 13, 2024
Closed
@sseemayer
Copy link
Owner

Thanks a lot for this fix! 👍🏻 👍🏻 - I changed your commit messages to conform to our required format so that CI checks pass but left everything else as-is.

@sseemayer sseemayer merged commit 3e99ccc into sseemayer:master Apr 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sseemayer sseemayer sseemayer approved these changes

@louib louib Awaiting requested review from louib louib is a code owner

@varjolintu varjolintu Awaiting requested review from varjolintu varjolintu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

save_kdbx4: Chunking by block size in hmac_block_stream corrupts database
2 participants
@baranyildirim @sseemayer