fix: make TOTP issuer field optional #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both per: - google authenticator wiki: https://github.com/google/google-authenticator/wiki/Key-Uri-Format#issuer - yubikey website: https://docs.yubico.com/yesdk/users-manual/application-oath/uri-string-format.html `issuer` parameter in `otpauth://` URI scheme is optional, even though it's highly recommended to be present. This parameter was actually optional in this repo initially, but was changed to non optional. I'm changing it back to optional.
tadic-luka
requested review from
sseemayer,
louib and
varjolintu
as code owners
sseemayer
approved these changes
Sep 8, 2024
louib
approved these changes
Sep 8, 2024
|
@louib I can see that the commit message CI action failed and I also saw that you updated the config to allow lines with > 100 chars. How do I re-run the workflow? Do I need to update the commit somehow? |
|
@tadic-luka once my PR is merged, you can simply rebase your PR and the check should pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both per:
issuerparameter inotpauth://URI scheme is optionaleven though it's highly recommended to be present.
This parameter was actually optional in this repo initially
(in 0089160)
but was changed to non optional.
I'm changing it back to optional.
BREAKING CHANGE: makes
issuerparameter Option instead of String