Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md - Fix Base46 input example #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oviliz
Copy link

@oviliz oviliz commented Sep 4, 2023

Fixing Base46 input example when the following error occurs:

    print mysid
    ^^^^^^^^^^^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print(...)?

@oviliz
Copy link
Author

oviliz commented Sep 4, 2023

@sspreitzer do you mind reviewing this?

Copy link
Owner

@sspreitzer sspreitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also increase the version of the package in the setup file?
Thank you

@oviliz
Copy link
Author

oviliz commented Sep 5, 2023

@sspreitzer happy with a minor version change?
version = "0.2.1",

@sspreitzer
Copy link
Owner

@sspreitzer happy with a minor version change?
version = "0.2.1",

Sure, if it is working. 👍

@oviliz
Copy link
Author

oviliz commented Sep 5, 2023

@sspreitzer I have ended up doing 0.3 as I'm using VSCode with Black auto-formatter and have also done it on all Python scripts at this point. Tested without any issues.

❯ python3 setup.py install
running install
/usr/local/lib/python3.11/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(
/usr/local/lib/python3.11/site-packages/setuptools/command/easy_install.py:144: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(
running bdist_egg
running egg_info
writing src/sid.egg-info/PKG-INFO
writing dependency_links to src/sid.egg-info/dependency_links.txt
writing top-level names to src/sid.egg-info/top_level.txt
reading manifest file 'src/sid.egg-info/SOURCES.txt'
adding license file 'LICENSE'
writing manifest file 'src/sid.egg-info/SOURCES.txt'
installing library code to build/bdist.macosx-11-x86_64/egg
running install_lib
running build_py
creating build/bdist.macosx-11-x86_64/egg
creating build/bdist.macosx-11-x86_64/egg/sid
copying build/lib/sid/lib.py -> build/bdist.macosx-11-x86_64/egg/sid
copying build/lib/sid/__init__.py -> build/bdist.macosx-11-x86_64/egg/sid
copying build/lib/sid/test_lib.py -> build/bdist.macosx-11-x86_64/egg/sid
byte-compiling build/bdist.macosx-11-x86_64/egg/sid/lib.py to lib.cpython-311.pyc
byte-compiling build/bdist.macosx-11-x86_64/egg/sid/__init__.py to __init__.cpython-311.pyc
byte-compiling build/bdist.macosx-11-x86_64/egg/sid/test_lib.py to test_lib.cpython-311.pyc
creating build/bdist.macosx-11-x86_64/egg/EGG-INFO
copying src/sid.egg-info/PKG-INFO -> build/bdist.macosx-11-x86_64/egg/EGG-INFO
copying src/sid.egg-info/SOURCES.txt -> build/bdist.macosx-11-x86_64/egg/EGG-INFO
copying src/sid.egg-info/dependency_links.txt -> build/bdist.macosx-11-x86_64/egg/EGG-INFO
copying src/sid.egg-info/top_level.txt -> build/bdist.macosx-11-x86_64/egg/EGG-INFO
zip_safe flag not set; analyzing archive contents...
creating 'dist/sid-0.3-py3.11.egg' and adding 'build/bdist.macosx-11-x86_64/egg' to it
removing 'build/bdist.macosx-11-x86_64/egg' (and everything under it)
Processing sid-0.3-py3.11.egg
Copying sid-0.3-py3.11.egg to /usr/local/lib/python3.11/site-packages
Removing sid 0.2.1 from easy-install.pth file
Adding sid 0.3 to easy-install.pth file

Installed /usr/local/lib/python3.11/site-packages/sid-0.3-py3.11.egg
Processing dependencies for sid==0.3
Finished processing dependencies for sid==0.3

Tests:

cd src/sid/
❯ python3 -m unittest
......
----------------------------------------------------------------------
Ran 6 tests in 0.000s

OK

Usage:

cd ../../
❯ cat > convert.py << EOF
import sid

mysid = sid.sid('AQUAAAAAAAUVAAAAoGXPfnhLm1/nfIdwCRwBAA==', sid.SID_BASE64)
print(mysid)
EOF
❯ python3 convert.py
S-1-5-21-2127521184-1604012920-1887927527-72713

@oviliz
Copy link
Author

oviliz commented Sep 11, 2023

@sspreitzer just a heads up reminder about this PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants