Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ArcGIS FeatureServer Link #27

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

smohiudd
Copy link

@smohiudd smohiudd commented Nov 5, 2024

Description

The NASA Impact VEDA project is working on referencing ArcGIS datasets in our STAC Catalog. We are doing this through the pyarc2stac library that gathers ArcGIS metadata and creates STAC collections. References to ArcGIS servers are captured in the Collection links list while using the web-map-links extension.

This PR adds FeatureServer as an option for web map links.

@smohiudd
Copy link
Author

smohiudd commented Feb 3, 2025

@m-mohr do you have any thoughts/comments on this PR?

| rel | string | **REQUIRED**. Must be set to `featureserver`. |
| href | string | **REQUIRED**. Link to a FeatureServer service. Usually has the following form `https://<root>/<serviceName>/FeatureServer` |
| type | string | Recommended to be set to `application/json` |
| featureserver:layers | Map<string, string> | The layers included in the service. The key should be used as the `LayerId` when querying the service. For example: `https://<root>/<serviceName>/FeatureServer/<layerId>/query` |
Copy link
Contributor

@m-mohr m-mohr Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What purpose do the values have here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

href and featureserver:layers can be used by a client to determine which layers are available for query directly without having to recursively search for layers in the json response.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the key is used in the URL template, but the value is just for visualization purposes then? I don't see that being used directly...


| Field Name | Type | Description |
| --------------- | -------------------- | ----------- |
| rel | string | **REQUIRED**. Must be set to `featureserver`. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that a well-known standard or is the only software for this ArcGIS? If not, I'd propose to switch to

Suggested change
| rel | string | **REQUIRED**. Must be set to `featureserver`. |
| rel | string | **REQUIRED**. Must be set to `arcgis-featureserver`. |

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is specific to Arcgis only. Agree.

Comment on lines +178 to +187
"then": {
"properties": {
"pmtiles:layers": {
"type": "object",
"items": {
"type": "string",
"minItems": 1,
"items": {
"type": "string",
"minLength": 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema is wrong.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will look at this again

Copy link
Contributor

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. See comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants