Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add numberReturned and numberMatched fields to ItemCollection #254

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Add numberReturned and numberMatched fields to ItemCollection #254

merged 1 commit into from
Apr 11, 2024

Conversation

drnextgis
Copy link
Collaborator

ref: radiantearth/stac-api-spec#396
ref: stac-utils/stac-fastapi#478

The context extension is deprecated.

@drnextgis drnextgis marked this pull request as draft April 9, 2024 21:36
@drnextgis drnextgis force-pushed the context branch 3 times, most recently from f06c0a6 to 37e5f5f Compare April 9, 2024 22:24
@drnextgis drnextgis marked this pull request as ready for review April 9, 2024 22:43
@drnextgis
Copy link
Collaborator Author

@bitner please review and let me know whether you believe we should also consider updating collection_search?

@vincentsarago
Copy link
Member

thanks @drnextgis 🙏

@bitner
Copy link
Collaborator

bitner commented Apr 10, 2024

@drnextgis This looks great, if you are up to changing in collection_search as well, that would be awesome. I don't have strong feelings about this, but do we want an option to use the deprecated context still for any clients that continue to expect that?

@drnextgis
Copy link
Collaborator Author

collection_search has been updated, and tests have been adjusted

@drnextgis
Copy link
Collaborator Author

drnextgis commented Apr 11, 2024 •
edited
Loading

@drnextgis This looks great, if you are up to changing in collection_search as well, that would be awesome. I don't have strong feelings about this, but do we want an option to use the deprecated context still for any clients that continue to expect that?

I don't have strong feelings either. Documenting it as a backwards incompatible change in the changelog should suffice. In stac-pydantic it was removed by @vincentsarago.

@vincentsarago
Copy link
Member

I don't have strong feelings either. Documenting it as a backwards incompatible change in the changelog should suffice. In stac-pydantic it was stac-utils/stac-pydantic#138 by @vincentsarago.

The ContextExtension is deprecated and will be removed in next version of stac-fastapi stac-utils/stac-fastapi#649

@bitner
Copy link
Collaborator

bitner commented Apr 11, 2024 via email

@bitner bitner merged commit e5be8a7 into stac-utils:main Apr 11, 2024
15 checks passed
@drnextgis drnextgis deleted the context branch April 11, 2024 14:23
@jonhealy1 jonhealy1 mentioned this pull request May 12, 2024
Merged
4 tasks
jonhealy1 added a commit to stac-utils/stac-fastapi-elasticsearch-opensearch that referenced this pull request May 13, 2024
@jonhealy1
Remove deprecated context extension (#255)
032173b 
**Related Issue(s):**

- radiantearth/stac-api-spec#396
- stac-utils/pgstac#254

**Description:**


**PR Checklist:**

- [x] Code is formatted and linted (run `pre-commit run --all-files`)
- [x] Tests pass (run `make test`)
- [x] Documentation has been updated to reflect changes, if applicable
- [x] Changes are added to the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentsarago vincentsarago vincentsarago approved these changes

@bitner bitner bitner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drnextgis @vincentsarago @bitner