-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify requests with REQUESTS_CA_BUNDLE if set #665
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #665 +/- ##
==========================================
+ Coverage 93.43% 93.68% +0.24%
==========================================
Files 13 13
Lines 990 997 +7
==========================================
+ Hits 925 934 +9
+ Misses 65 63 -2 ☔ View full report in Codecov by Sentry. |
Updated to include fallback to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I totally missed |
Closing in favor of #669 |
Related Issue(s):
REQUESTS_CA_BUNDLE
environment variable #664Description: By default, the basic
requests.get
,requests.post
, etc., functions look for an environment variableREQUESTS_CA_BUNDLE
(see docs), which can point to a custom certificate bundle file instead of the default bundle provided withcertifi
. This is common practice in e.g., corporate settings where HTTPS inspection is being performed with SSL certificate replacement, causing HTTPS responses with odd-looking certificates. This PR ensures thatpystac-client
also respects theREQUESTS_CA_BUNDLE
environment variable.PR Checklist: