Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the _stac_io on a collection client #709

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Set the _stac_io on a collection client #709

merged 3 commits into from
Jul 1, 2024

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Jul 1, 2024 •
edited
Loading

Related Issue(s):

Description:

Includes:

  • Bugfix where we weren't actually setting timeout correctly on StacApiIO initialization
  • Some ruff config updates

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@gadomski
fix: pass timeout to update
2d327bb 
Without this fix, we couldn't actually initialize with a timeout.
@gadomski gadomski requested a review from jsignell July 1, 2024 14:19
@gadomski gadomski self-assigned this Jul 1, 2024
@gadomski gadomski force-pushed the issues/706-remove-get-root branch from 4a317ca to 9a5fb0b Compare July 1, 2024 14:20
@gadomski gadomski mentioned this pull request Jul 1, 2024
Closed
@gadomski gadomski merged commit 9a6e128 into main Jul 1, 2024
17 checks passed
@gadomski gadomski deleted the issues/706-remove-get-root branch July 1, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

@jsignell jsignell Awaiting requested review from jsignell

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

using StacApiIO with regular pystac breaks
2 participants
@gadomski @TomAugspurger