Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make test #287

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Fix make test #287

merged 1 commit into from
Aug 23, 2024

Conversation

kurtmckee
Copy link
Contributor

@kurtmckee kurtmckee commented Aug 22, 2024

Description:

make test references an undefined variable, APP_PORT, which causes the the docker-compose command's -p argument to be malformed:

docker-compose run -p  :8080 ...
                      ^--- missing the left-side port!

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
    The test failure in CI appears to be unrelated to this change.
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

@jonhealy1 jonhealy1 self-requested a review August 22, 2024 19:16
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jonhealy1 jonhealy1 merged commit 9a51574 into stac-utils:main Aug 23, 2024
15 checks passed
@kurtmckee kurtmckee deleted the fix-make-test branch August 23, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants