Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection search draft #298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ccancellieri
Copy link

Related Issue(s):

Hi, I'm using this branch to discuss about collection search which is an hot topic for me and I needed to sort it out as per this pull request.

I'm encountering the following problems:

  • We still need to use the POST to create new Collection(s) but the incoming expexted body is different
  • Incompatible with Transactional (how to have it working?)

[The pull request uses another endpoint to avoid the clash]

Questions:

  • Why the specifications define a new endpoint to search for items: .../search while for the collections we are overloading the /collections ?
  • Do you have any working example about having both search and creation working at the same time?

Description:

This patch reduced code duplication and implements the same search capabilities that we have over items but over collections returning a standard (?) /collections search response with the result of the search in the collection index.

The collectionID list for now is simply ignored.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

@jonhealy1
Copy link
Collaborator

Hi @ccancellieri. Could you open an issue here. Your concerns are valid I think. We are limited by the stac-fastapi parent libraries and then also the stac-api-spec.

@ccancellieri
Copy link
Author

here it is:
stac-utils/stac-fastapi#749

@jonhealy1
Copy link
Collaborator

@ccancellieri great thank you!

@ccancellieri
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants