Aggregation Bugfix and Documentation Update #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jonhealy1 This should fix the issue you raised in #290. Thanks for that. I still have no idea why that was only an intermittent issue with the test, but this should fix that. I also moved the aggregation text from the core readme to the docs. Is this a good place for it? Felt like the aggregation text was making the core readme too long 😅 |
|
Nice fix. Moving the documentation definitely works. I was also thinking before about having a table of contents at the top of the readme. |
StijnCaerts
approved these changes
Nov 28, 2024
|
Looks good, thanks for the fix! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Includes a bugfix for Elasticsearch aggregation, the indices() function was only checking if the input was None. But in POST requests the input is an empty list ({}). So that was leading to some aggregations to search through all indices in an Elasticsearch cluster, not just the items indices.
PR Checklist:
pre-commit run --all-files)make test)