update pre-commit and use ruff for linting/formating #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Apr 23, 2024
| @@ -57,7 +56,7 @@ | |||
| api = StacApi( | |||
| settings=settings, | |||
| extensions=extensions, | |||
| client=CoreCrudClient(post_request_model=post_request_model), | |||
| client=CoreCrudClient(post_request_model=post_request_model), # type: ignore | |||
There was a problem hiding this comment.
not sure why I was getting a Mypy error here 🤷
vincentsarago
commented
Apr 23, 2024
| collection_id=collection_id, | ||
| item_id=item_id, | ||
| collection_id=collection_id, # type: ignore | ||
| item_id=item_id, # type: ignore |
There was a problem hiding this comment.
collection_id and item_id should always be define but for some reason mypy thinks it can be None
vincentsarago
commented
Apr 23, 2024
| with translate_pgstac_errors(): | ||
| async with pool.acquire() as conn: | ||
| yield conn | ||
|
|
||
|
|
||
| async def dbfunc(conn: Connection, func: str, arg: Union[str, Dict]): | ||
| async def dbfunc(conn: Connection, func: str, arg: Union[str, Dict, List]): |
vincentsarago
commented
Apr 23, 2024
| "rel": Relations.self.value, | ||
| "type": MimeTypes.json.value, | ||
| "href": self.url, | ||
| } |
There was a problem hiding this comment.
FYI: using dict() is slower than constructing a dict using {}
vincentsarago
commented
Apr 23, 2024
| @@ -28,7 +28,7 @@ | |||
| class TransactionsClient(AsyncBaseTransactionsClient): | |||
| """Transactions extension specific CRUD operations.""" | |||
|
|
|||
| def _validate_id(self, id: str, settings: Settings) -> bool: | |||
| def _validate_id(self, id: str, settings: Settings): | |||
There was a problem hiding this comment.
there is no return on this function
vincentsarago
commented
Apr 23, 2024
| @@ -153,7 +151,8 @@ async def test_returns_valid_links_in_collections(app_client, load_test_data): | |||
| # Find collection in list by ID | |||
| single_coll = next(coll for coll in collections if coll["id"] == in_json["id"]) | |||
| is_coll_from_list_valid = False | |||
| single_coll_mocked_link = dict() | |||
|
|
|||
| single_coll_mocked_link: Optional[pystac.Collection] = None | |||
There was a problem hiding this comment.
single_coll_mocked_link can't be a dict but has to be a Collection object
jonhealy1
approved these changes
Apr 24, 2024
|
@vincentsarago changelog? |
|
@jonhealy1 I'll wait for #101 to get merged then I'll merge this one to main and then we can do #106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates pre-commit and switch to ruff for formatting/linting (as we did in stac-fastapi)