Allow upserting data via bulk transaction requests #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 23, 2023 11:42
… bulk transaction method param
4 tasks
added 2 commits
November 17, 2023 13:52
gadomski
approved these changes
Nov 24, 2023
gadomski
requested changes
Nov 24, 2023
…ng the same items twice
edkeeble
force-pushed
the
upsert-bulk-transactions
branch
from
9d1ff59 to
0f45da7
Compare
@gadomski Yep, added a couple of tests to confirm the expected behavior. I also modified the response message to reflect the provided insert method (while retaining "added" for the insert method, for the purposes of backward compatibility). Not sure how you feel about that, but happy to revert it to always return "added". |
gadomski
approved these changes
Nov 30, 2023
|
@edkeeble thanks for the tests! Do you need a release w/ these changes? |
|
@gadomski Yes, please. I'll put a separate PR up for the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Along with this PR on stac-fastapi, this change allows a client to make use of the
upsert_itemsfunction by way of the Bulk Transactions extension.PR Checklist:
pre-commithooks pass locallymake test)make docs)