Response models are not being used to validate responses

[drnextgis]

I've got confused by the fact that response models are not being used to validate responses. Isn't that its main purpose? As you can see here for example response model is Collection. But if we modify collection's content in the database (pgstac) in order not to be align with the response model stac-fastapi simple ignores it and returns what we have in the database without any warning/error:

$ postgis=# UPDATE collections SET content = JSONB_SET(content, '{type}', '"MyCollection"');

$ curl -s -X 'GET' \
  'http://localhost:8082/collections/joplin' \
  -H 'accept: application/json' | jq '.type'
"MyCollection"

But according to the response model type should be Collection.

ENABLE_RESPONSE_MODELS set to true

[gadomski]

I believe you're correct -- I've opened #519 to track the issue. Currently I just have a failing test to demonstrate the issue.

[vincentsarago]

I confirmed this.

The thing was that we are using wrap_response to make sure the endpoints return a starlette Response, but this issue is then FastAPI will not run pydantic validation/serialization if the endpoint respond a Response object

stac-fastapi/stac_fastapi/api/stac_fastapi/api/routes.py

Lines 18 to 24 in 4fb10ec

	def _wrap_response(resp: Any, response_class: Type[Response]) -> Response:
	if isinstance(resp, Response):
	return resp
	elif resp is not None:
	return response_class(resp)
	else: # None is returned as 204 No Content
	return Response(status_code=HTTP_204_NO_CONTENT)

I've changed this in thomas-maschler#2 for next stac-fastapi major version and will also change this for ~2.4 (maybe 2.5) #650 (comment)

[vincentsarago]

I believe this is not fixed and tested