-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add benchmark #650
Merged
vincentsarago
merged 8 commits into
stac-utils:main
from
vincentsarago:feature/benchmark
Apr 8, 2024
Merged
add benchmark #650
vincentsarago
merged 8 commits into
stac-utils:main
from
vincentsarago:feature/benchmark
Apr 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Apr 8, 2024
vincentsarago
commented
Apr 8, 2024
vincentsarago
commented
Apr 8, 2024
vincentsarago
force-pushed
the
feature/benchmark
branch
from
April 8, 2024 11:02
0f931fc
to
f9c4402
Compare
This comment was marked as outdated.
This comment was marked as outdated.
A small difference maybe. What if it ran with larger items? It probably wouldn't make much difference. |
WoW 🤯 well this is the same as thomas-maschler#2, in fact validation was never called 🤦 |
vincentsarago
commented
Apr 8, 2024
vincentsarago
commented
Apr 8, 2024
🥳
|
vincentsarago
commented
Apr 8, 2024
vincentsarago
commented
Apr 8, 2024
This PR also fix #461 |
vincentsarago
commented
Apr 8, 2024
gadomski
reviewed
Apr 8, 2024
Co-authored-by: Pete Gadomski <[email protected]>
…arturo-stac-api into feature/benchmark
@jonhealy1 @gadomski could you approve this PR 🙏 |
gadomski
approved these changes
Apr 8, 2024
jonhealy1
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.