Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pgstac queryables #474

Merged
merged 6 commits into from
Oct 5, 2022
Merged

Pgstac queryables #474

merged 6 commits into from
Oct 5, 2022

Conversation

bitner
Copy link
Collaborator

@bitner bitner commented Oct 3, 2022

Related Issue(s):

  • Partially fixes Queryables link relation and endpoint issues #469. This does not add the queryables link to / or /collections/{collection_id}/queryables to keep the scope of this fix to the pgstac backend. Currently there is no (at least that I am aware of) mechanism to inject extra links as part of an extension, so hardcoding the queryables links will result in bad links when the FilterExtension is not enabled.

Description:
Adds support to pgstac backend queryables functionality added in pgstac v0.6.8.

  • Adds /queryables endpoint
  • Adds /collections/{collection_id}/queryables endpoint

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@bitner bitner requested a review from lossyrob October 3, 2022 18:45
@bitner bitner marked this pull request as ready for review October 3, 2022 18:45
@bitner bitner requested a review from mmcfarland October 3, 2022 18:46
@geospatial-jeff
Copy link
Collaborator

Currently there is no (at least that I am aware of) mechanism to inject extra links as part of an extension, so hardcoding the queryables links will result in bad links when the FilterExtension is not enabled.

You may currently do this with conformance classes but not links. This will be easier to add once #432 is resolved. #472 is part of that larger effort and moves in the direction of making links easier to customize but I hadn't thought of the case where an extension requires additional links so I created #475 to track that.

Copy link
Collaborator

@geospatial-jeff geospatial-jeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bitner bitner merged commit fbdd993 into stac-utils:master Oct 5, 2022
@carderne
Copy link
Contributor

carderne commented Oct 6, 2022

Sorry for possibly misplaced question but:
Currently setting a bbox in the Collection Filter dialog in stac-browser doesn't work with stac-fastapi - it just calls /collections{collection_id}/items with bbox=1,2,3,4, which is ignored in the route.

Will this fix that? If not where should I go looking to get that to work? (Aside from monkey-patching in some code to use bbox in that route...)

@bitner
Copy link
Collaborator Author

bitner commented Oct 6, 2022

Sorry for possibly misplaced question but: Currently setting a bbox in the Collection Filter dialog in stac-browser doesn't work with stac-fastapi - it just calls /collections{collection_id}/items with bbox=1,2,3,4, which is ignored in the route.

Will this fix that? If not where should I go looking to get that to work? (Aside from monkey-patching in some code to use bbox in that route...)

No, this does not add that capability. As far as i know, that is not part of the stac specification. You can bring things like this up by adding an issue rather than replying to unrelated pull requests.

@carderne
Copy link
Contributor

carderne commented Oct 6, 2022

I'm trying to figure out how filtering is "supposed" to work, and whether the issue is with stac-browser, stac-fastapi, or pgstac. There's been a lot of recent activity in all three projects around this, so I didn't want to open an issue if it was already in the process of being resolved. Sorry for wasting your time.

@bitner
Copy link
Collaborator Author

bitner commented Oct 6, 2022 via email

@carderne
Copy link
Contributor

carderne commented Oct 6, 2022

👍 #476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Queryables link relation and endpoint issues
4 participants