Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backend-specific dockerfiles, publish images #525

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Feb 7, 2023

Related Issue(s):

Description:

Most of the changes to the main Dockerfile from #379 were implemented in #391. I think the remaining tasks were the deployable images for each backend. This PR adds those deployable images, some example docker-composes, and a section to the README.

Couple of notes:

  • I also bumped the pgstac versions in CI to v0.6.13
  • I moved the Dockerfiles to a docker/ folder, since the top-level was getting a little polluted w/ my two new Dockerfiles
  • The package registry is currently set to private. Once this PR is approved, we should make it public
  • I think my tagging should work as described in the README, but this could require a follow-up PR if I didn't get it quite right -- as always, testing CI-based stuff is a bit trial-and-error.
  • These dockerfiles should be easily portable to the backend repos as a part of Split backends into independent repos #432, and that split will make the image tagging story much simpler

The backend-specific images are significantly smaller than the dev build:

Screenshot 2023-02-09 at 7 26 13 AM

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.
  • (once approved) Make the package registry public

@gadomski gadomski added this to the 2.4.4 milestone Feb 7, 2023
@gadomski gadomski self-assigned this Feb 7, 2023
@gadomski gadomski force-pushed the issues/379-docker-improvements branch 8 times, most recently from ee532f7 to cf4a2db Compare February 9, 2023 14:17
@gadomski gadomski marked this pull request as ready for review February 9, 2023 14:23
@gadomski gadomski force-pushed the issues/379-docker-improvements branch from cf4a2db to 8736777 Compare February 9, 2023 14:27
@moradology moradology force-pushed the issues/379-docker-improvements branch from 8736777 to 273ae77 Compare February 23, 2023 15:50
Copy link
Collaborator

@moradology moradology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't think I have the permissions necessary to enable public container publishing. Reminder that this should be sorted out prior to merge

@gadomski gadomski merged commit 7ba0a40 into master Feb 23, 2023
@gadomski gadomski deleted the issues/379-docker-improvements branch February 23, 2023 21:42
@gadomski
Copy link
Member Author

Looks like it worked (from https://github.com/stac-utils/stac-fastapi/pkgs/container/stac-fastapi):

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put docker image on GHCR Dockerfile improvements, and and deployable version (comments and questions)
2 participants