Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add python 3.12 support and some docker cleanup #654

Merged
merged 2 commits into from
Apr 10, 2024
Merged

add python 3.12 support and some docker cleanup #654

merged 2 commits into from
Apr 10, 2024

Conversation

vincentsarago
Copy link
Member

This PR does:

  • add python 3.12 support
  • removes unused docker service in CI
  • other: pip -> python -m pip (this is to make sure it use the correct pip or pytest module when working with virtual environment)

@vincentsarago vincentsarago requested a review from jonhealy1 April 10, 2024 08:54
jonhealy1
jonhealy1 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@vincentsarago vincentsarago merged commit 8169e86 into main Apr 10, 2024
7 checks passed
@vincentsarago vincentsarago deleted the feature/add-python-3.12-and-docker-cleanup branch April 10, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhealy1 jonhealy1 jonhealy1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentsarago @jonhealy1