Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update context.py #660

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Update context.py #660

merged 5 commits into from
Apr 18, 2024

Conversation

jon9595
Copy link
Contributor

@jon9595 jon9595 commented Apr 18, 2024

typo in warning, "warm" insteand of "warn"

Related Issue(s):

Description:

Typo in warning call. Currently is warnings.warm() instead of warnings.warn()

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

typo in warning, "warm" insteand of "warn"
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good thank you. Could you add an entry in the changelog? I think we need to push a bugfix for this asap.

@jonhealy1
Copy link
Collaborator

There's this here too:

if response_class:
warnings.warns(
"`response_class` option is deprecated, please set the Response class directly in the endpoint.", # noqa: E501
DeprecationWarning,
)

@jon9595
Copy link
Contributor Author

jon9595 commented Apr 18, 2024

This is really good thank you. Could you add an entry in the changelog? I think we need to push a bugfix for this asap.

How do you want me to version it in the changelog?

@jon9595
Copy link
Contributor Author

jon9595 commented Apr 18, 2024

I think I got the changelog right, but the tag isn't showing. Sorry I'm not familiar with your versioning scheme, but let me know if I need to change it!

@jonhealy1
Copy link
Collaborator

It would just go under a Fixed section under Unreleased for now ie

## [Unreleased]

### Fixed

* Fixed warnings in ..... ([#660](https://github.com/stac-utils/stac-fastapi/pull/660))
```

@jon9595
Copy link
Contributor Author

jon9595 commented Apr 18, 2024

It would just go under a Fixed section under Unreleased for now ie

## [Unreleased]

### Fixed

* Fixed warnings in ..... ([#660](https://github.com/stac-utils/stac-fastapi/pull/660))

Ah sorry, let me change it then really quick!

@jon9595
Copy link
Contributor Author

jon9595 commented Apr 18, 2024

Should be good now! Thanks for getting back on this so fast, my build was breaking with that bug!

@jonhealy1
Copy link
Collaborator

Thanks for this - mine too

CHANGES.md Outdated Show resolved Hide resolved
@jonhealy1 jonhealy1 self-requested a review April 18, 2024 05:29
@jonhealy1 jonhealy1 merged commit 1078c2d into stac-utils:main Apr 18, 2024
7 checks passed
@vincentsarago
Copy link
Member

@jonhealy1 can you take care of releasing 2.5.1 ?

@jonhealy1 jonhealy1 mentioned this pull request Apr 18, 2024
4 tasks
@jonhealy1
Copy link
Collaborator

@vincentsarago Done I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants