-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update context.py #660
Update context.py #660
Conversation
typo in warning, "warm" insteand of "warn"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really good thank you. Could you add an entry in the changelog? I think we need to push a bugfix for this asap.
There's this here too: stac-fastapi/stac_fastapi/api/stac_fastapi/api/routes.py Lines 47 to 51 in bc52635
|
How do you want me to version it in the changelog? |
fixing warn call
I think I got the changelog right, but the tag isn't showing. Sorry I'm not familiar with your versioning scheme, but let me know if I need to change it! |
It would just go under a Fixed section under Unreleased for now ie
|
Ah sorry, let me change it then really quick! |
Should be good now! Thanks for getting back on this so fast, my build was breaking with that bug! |
Thanks for this - mine too |
@jonhealy1 can you take care of releasing 2.5.1 ? |
@vincentsarago Done I think |
typo in warning, "warm" insteand of "warn"
Related Issue(s):
Description:
Typo in warning call. Currently is
warnings.warm()
instead ofwarnings.warn()
PR Checklist:
pre-commit
hooks pass locallymake test
)make docs
)