Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove str2list converter from BaseSearchGetRequest #668

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

jonhealy1
Copy link
Collaborator

@jonhealy1 jonhealy1 commented Apr 22, 2024

Related Issue(s):

Description:

The str2list converter on the intersection converter results in some hacky code needed in downstream backends.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@jonhealy1 jonhealy1 merged commit 085bcd7 into main Apr 22, 2024
7 checks passed
@jonhealy1 jonhealy1 deleted the GET-search-intersection-fix branch April 22, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants