Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move pagination models to extensions submodule #717

Merged
merged 5 commits into from
Jul 1, 2024

Conversation

vincentsarago
Copy link
Member

This was adding useless circular dependency between api and extensions

@vincentsarago vincentsarago requested a review from jonhealy1 June 25, 2024 17:55
CHANGES.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just the changelog entry

@vincentsarago vincentsarago requested a review from jonhealy1 July 1, 2024 08:52
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@vincentsarago vincentsarago merged commit 270e03d into main Jul 1, 2024
7 checks passed
@vincentsarago vincentsarago deleted the feature/move-pagination-models branch July 1, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants