Separating route securities from other dependencies. #766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Currently if you have more than one security dependency on a single route, if either fail then the route will be unauthorised. This is a known issue in FastAPI and the suggested solution is to use a single dependency to merge the sub dependencies. This makes configuration more difficult and removes the ability to use default security dependencies.
Suggested solution is to separate route securities from other dependencies. This then allows them to be merged when dynamically.
There are two options for merging in this pull request.
merge_dependencies1
uses the traditional merging method but this requires dependencies return a value orNone
rather than raise an error. This means it would need to be used for all routes even those without multiple dependencies.merge_dependencies2
calls each dependency itself which allows them to raise their own errors so can be used only on routes that have multiple dependencies.PR Checklist:
pre-commit
hooks pass locallymake test
)make docs
)