-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Support for Mimic Joint #2441
base: devel
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:
- build_collision (build Pinocchio with coal support)
- build_casadi (build Pinocchio with CasADi support)
- build_autodiff (build Pinocchio with CppAD support)
- build_codegen (build Pinocchio with CppADCodeGen support)
- build_extra (build Pinocchio with extra algorithms)
- build_mpfr (build Pinocchio with Boost.Multiprecision support)
- build_sdf (build Pinocchio with SDF parser)
- build_accelerate (build Pinocchio with APPLE Accelerate framework support)
- build_all (build Pinocchio with ALL the options stated above)
Thanks.
The Pinocchio development team.
c43fad1
to
52358ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will provide a detailed review later.
3f25772
to
5ea8402
Compare
…tivePlacement to remove redundant computations
… code to prevent duplication
…template parameters
… to DEFINITION for transformJointIntoMimic
Overview
This PR enhances support for the mimic joint.$q_{mimic} = \alpha * q_{primary} + \beta$ (where $\alpha, \beta$ are defined by the user)
Mimic joint refer to a joint which configuration depends on the configuration of another joint (that we named the primary joint). The relation is
Key Updates:
URDF Parsing:
The mimic tag can now be parsed from urdf, and add the corresponding mimic joint to the model.
A
mimic
flag has been added to the parser to enable this feature or not (default tofalse
) in order to preserve backward compatibility.Robot and Joint Model Modifications:
nq
andnv
(resp.idx_q
,idx_v
) values have now been extended with anj
(respidx_j
) value, holding the dimension of the extended robot/joint tangeant space. (for all classical jointnv==nj
but for mimicnv==0
andnj==primary.nj
). The suffix j stand for Jacobian as those values are mainly used for computing jacobians rows and columns.Algorithms:
Testing & Validation:
Limitations:
Feedback Needed:
The naming of the new member variable and functions is pretty arbitrary, we are eager to change them to better suit pinocchio naming standards.
Non exhaustively, here are a list of the lesser quality one (that should most probably be renamed) :
idx_j
/nj
: representing the dimension and index in the "extended model"jointCols
,jointRows
, etc method has been split intojointVelCols
andjointJacCols
(respectively if they refer toidx_v
/nv
oridx_j
/nj
)jointConfigSelector
was splitted intojointConfigFromDofSelector
andjointConfigFromNqSelector
to meet the need for mimic joint to select config either from the parent joint or don't select anythingjointVelocitySelector
was splitted intojointVelocityFromDofSelector
andjointConfigFromNqSelector
to meet the need for mimic joint to select config either from the parent joint or don't select anythingSpecial Thanks:
A special thank you to @EtienneAr for his guidance and advice throughout this development process.