Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #223

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ ci:
autoupdate_branch: 'devel'
repos:
- repo: https://github.com/pre-commit/mirrors-clang-format
rev: v17.0.3
rev: v19.1.7
hooks:
- id: clang-format
args: ['--style={BasedOnStyle: Google,SortIncludes: false}']
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.5.0
rev: v5.0.0
hooks:
- id: check-added-large-files
- id: check-ast
Expand All @@ -25,11 +25,11 @@ repos:
- id: mixed-line-ending
- id: trailing-whitespace
- repo: https://github.com/psf/black
rev: 23.10.0
rev: 24.10.0
hooks:
- id: black
- repo: https://github.com/PyCQA/flake8
rev: 6.1.0
rev: 7.1.1
hooks:
- id: flake8
- repo: https://github.com/cheshirekow/cmake-format-precommit
Expand Down
2 changes: 1 addition & 1 deletion include/sot/core/binary-op.hh
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class BinaryOp : public Entity {
op.addSpecificCommands(*this, commandMap);
}

virtual ~BinaryOp(void){};
virtual ~BinaryOp(void) {};

public: /* --- SIGNAL --- */
SignalPtr<Tin1, sigtime_t> SIN1;
Expand Down
2 changes: 1 addition & 1 deletion include/sot/core/derivator.hh
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class Derivator : public dynamicgraph::Entity {
timestepSIN.setKeepReference(true);
}

virtual ~Derivator(void){};
virtual ~Derivator(void) {};

public: /* --- SIGNAL --- */
dynamicgraph::SignalPtr<T, sigtime_t> SIN;
Expand Down
2 changes: 1 addition & 1 deletion include/sot/core/feature-abstract.hh
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class SOT_CORE_EXPORT FeatureAbstract : public Entity {
/*! \brief Default constructor: the name of the class should be given. */
FeatureAbstract(const std::string &name);
/*! \brief Default destructor */
virtual ~FeatureAbstract(void){};
virtual ~FeatureAbstract(void) {};

/*! \name Methods returning the dimension of the feature.
@{ */
Expand Down
2 changes: 1 addition & 1 deletion include/sot/core/latch.hh
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class Latch : public Entity {
docCommandVoid0("Turn off the latch")));
}

virtual ~Latch(void){};
virtual ~Latch(void) {};
};
} /* namespace sot */
} /* namespace dynamicgraph */
Expand Down
2 changes: 1 addition & 1 deletion include/sot/core/parameter-server.hh
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class SOTParameterServer_EXPORT ParameterServer
/* --- CONSTRUCTOR ---- */
ParameterServer(const std::string &name);

~ParameterServer(){};
~ParameterServer() {};

/// Initialize
/// @param dt: control interval
Expand Down
2 changes: 1 addition & 1 deletion include/sot/core/sequencer.hh
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class SOTSEQUENCER_EXPORT Sequencer : public dynamicgraph::Entity {
size_type eventType;

public:
sotEventAbstract(const std::string &name) : name(name){};
sotEventAbstract(const std::string &name) : name(name) {};
virtual ~sotEventAbstract(void) {}
virtual const std::string &getName() const { return name; }
size_type getEventType() const { return eventType; }
Expand Down
2 changes: 1 addition & 1 deletion include/sot/core/smooth-reach.hh
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class SOTSMOOTHREACH_EXPORT SmoothReach : public dynamicgraph::Entity {

public: /* --- CONSTRUCTION --- */
SmoothReach(const std::string &name);
virtual ~SmoothReach(void){};
virtual ~SmoothReach(void) {};

public: /* --- SIGNAL --- */
dynamicgraph::SignalPtr<dynamicgraph::Vector, sigtime_t> startSIN;
Expand Down
3 changes: 1 addition & 2 deletions include/sot/core/sot.hh
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,7 @@ class SOTSOT_CORE_EXPORT Sot : public Entity {
public:
/*! \brief Default constructor */
Sot(const std::string &name);
~Sot(void) { /* TODO!! */
}
~Sot(void) { /* TODO!! */ }

/*! \name Methods to handle the stack.
@{
Expand Down
4 changes: 2 additions & 2 deletions include/sot/core/task-abstract.hh
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ class SOT_CORE_EXPORT TaskAbstract : public dynamicgraph::Entity {
/* Use a derivative of this class to store computational memory. */
class MemoryTaskAbstract {
public:
MemoryTaskAbstract(void){};
virtual ~MemoryTaskAbstract(void){};
MemoryTaskAbstract(void) {};
virtual ~MemoryTaskAbstract(void) {};

public:
virtual void display(std::ostream &os) const = 0;
Expand Down
2 changes: 1 addition & 1 deletion include/sot/core/unary-op.hh
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class UnaryOp : public Entity {
op.addSpecificCommands(*this, commandMap);
}

virtual ~UnaryOp(void){};
virtual ~UnaryOp(void) {};

public: /* --- SIGNAL --- */
SignalPtr<Tin, sigtime_t> SIN;
Expand Down
2 changes: 1 addition & 1 deletion include/sot/core/variadic-op.hh
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ class VariadicOp : public VariadicAbstract<typename Operator::Tin,
op.initialize(this, this->commandMap);
}

virtual ~VariadicOp(void){};
virtual ~VariadicOp(void) {};

protected:
Tout &computeOperation(Tout &res, sigtime_t time) {
Expand Down
14 changes: 7 additions & 7 deletions src/filters/filter-differentiator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -97,19 +97,19 @@ void FilterDifferentiator::init(const double &timestep, const size_type &xSize,
m_filter =
new CausalFilter(timestep, xSize, filter_numerator, filter_denominator);

LOG("Filtering started with "
<< "Numerator " << filter_numerator << std::endl
<< "Denominator" << filter_denominator << std::endl);
LOG("Filtering started with " << "Numerator " << filter_numerator << std::endl
<< "Denominator" << filter_denominator
<< std::endl);
return;
}

void FilterDifferentiator::switch_filter(
const Eigen::VectorXd &filter_numerator,
const Eigen::VectorXd &filter_denominator) {
LOG("Filter switched with "
<< "Numerator " << filter_numerator << std::endl
<< "Denominator" << filter_denominator << std::endl
<< "at time" << m_xSIN.getTime());
LOG("Filter switched with " << "Numerator " << filter_numerator << std::endl
<< "Denominator" << filter_denominator
<< std::endl
<< "at time" << m_xSIN.getTime());
m_filter->switch_filter(filter_numerator, filter_denominator);
}

Expand Down
4 changes: 2 additions & 2 deletions tests/tools/dummy-sot-external-interface.hh
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ typedef dynamicgraph::size_type size_type;
class DummySotExternalInterface
: public dynamicgraph::sot::AbstractSotExternalInterface {
public:
DummySotExternalInterface(){};
DummySotExternalInterface() {};

virtual ~DummySotExternalInterface(){};
virtual ~DummySotExternalInterface() {};

virtual void setupSetSensors(
std::map<std::string, dynamicgraph::sot::SensorValues> &sensorsIn);
Expand Down
4 changes: 2 additions & 2 deletions tests/tools/plugin.cc
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ class Plugin : public PluginAbstract {
AbstractSotExternalInterface *sotController_;

public:
Plugin(){};
~Plugin(){};
Plugin() {};
~Plugin() {};

void Initialization(std::string &dynamicLibraryName) {
// Load the SotRobotBipedController library.
Expand Down
4 changes: 2 additions & 2 deletions tests/tools/plugin.hh
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@

class PluginAbstract {
public:
PluginAbstract(){};
virtual ~PluginAbstract(){};
PluginAbstract() {};
virtual ~PluginAbstract() {};
virtual void Initialization(std::string &astr) = 0;
};

Expand Down
4 changes: 2 additions & 2 deletions tests/tools/test_abstract_interface.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ class PluginLoader {
std::string dynamicLibraryName_;

public:
PluginLoader(){};
~PluginLoader(){};
PluginLoader() {};
~PluginLoader() {};

int parseOptions(int argc, char *argv[]) {
po::options_description desc("Allowed options");
Expand Down