Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report patchable fetch progress #1007

Merged
merged 4 commits into from
Feb 25, 2025
Merged

Report patchable fetch progress #1007

merged 4 commits into from
Feb 25, 2025

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Feb 20, 2025

Description

Fetching upstream repositories can be pretty slow, so we should report progress as we do.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Tasks

Preview Give feedback
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@nightkr nightkr requested a review from a team February 20, 2025 11:35
Copy link
Member

@dervoeti dervoeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nightkr nightkr added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit abf9eb1 Feb 25, 2025
3 checks passed
@nightkr nightkr deleted the feature/patchable-progress branch February 25, 2025 15:52
dervoeti pushed a commit that referenced this pull request Feb 26, 2025
* Report patchable fetch progress

* Avoid clobbering child processes' output

* Fix rustdoc warnings

* Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants