Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs maintenance #625

Merged
merged 23 commits into from
Jun 17, 2024
Merged

Docs maintenance #625

merged 23 commits into from
Jun 17, 2024

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Jun 4, 2024 •
edited
Loading

Description

  • formatting
  • an image that was previously on GitHub is now added to Antora itself.
  • add info on Pod overrides

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@fhennig fhennig self-assigned this Jun 5, 2024
NickLarsenNZ
NickLarsenNZ requested changes Jun 10, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this was late. I forgot I had it open in another tab last week.

docs/modules/nifi/pages/getting_started/installation.adoc Outdated Show resolved Hide resolved
docs/modules/nifi/pages/usage_guide/configuration-environment-overrides.adoc Outdated Show resolved Hide resolved
docs/modules/nifi/pages/usage_guide/configuration-environment-overrides.adoc Outdated Show resolved Hide resolved
docs/modules/nifi/pages/usage_guide/configuration-environment-overrides.adoc Outdated Show resolved Hide resolved
docs/modules/nifi/pages/usage_guide/configuration-environment-overrides.adoc Outdated Show resolved Hide resolved
docs/modules/nifi/pages/usage_guide/operations/cluster-operations.adoc Outdated Show resolved Hide resolved
docs/modules/nifi/pages/usage_guide/security.adoc Outdated Show resolved Hide resolved
docs/modules/nifi/pages/usage_guide/updating.adoc Outdated Show resolved Hide resolved
docs/modules/nifi/pages/usage_guide/zookeeper-connection.adoc Outdated Show resolved Hide resolved
docs/modules/nifi/pages/usage_guide/zookeeper-connection.adoc Outdated Show resolved Hide resolved
fhennig and others added 16 commits June 11, 2024 09:16
@fhennig @NickLarsenNZ
Update docs/modules/nifi/pages/usage_guide/configuration-environment-…
aad3132 
…overrides.adoc

Co-authored-by: Nick <[email protected]>
@fhennig @NickLarsenNZ
Update docs/modules/nifi/pages/usage_guide/configuration-environment-…
38e016d 
…overrides.adoc

Co-authored-by: Nick <[email protected]>
@fhennig @NickLarsenNZ
Update docs/modules/nifi/pages/usage_guide/updating.adoc
cc6c762 
Co-authored-by: Nick <[email protected]>
@fhennig @NickLarsenNZ
Update docs/modules/nifi/pages/usage_guide/zookeeper-connection.adoc
8bb0bf8 
Co-authored-by: Nick <[email protected]>
@fhennig @NickLarsenNZ
Update docs/modules/nifi/pages/usage_guide/zookeeper-connection.adoc
24d3a08 
Co-authored-by: Nick <[email protected]>
@fhennig @NickLarsenNZ
Update docs/modules/nifi/pages/usage_guide/security.adoc
c96fe47 
Co-authored-by: Nick <[email protected]>
@fhennig @NickLarsenNZ
Update docs/modules/nifi/pages/usage_guide/operations/cluster-operati…
b6cf8a0 
…ons.adoc

Co-authored-by: Nick <[email protected]>
@fhennig @NickLarsenNZ
Update docs/modules/nifi/pages/usage_guide/extra-volumes.adoc
94114fc 
Co-authored-by: Nick <[email protected]>
@fhennig @NickLarsenNZ
Update docs/modules/nifi/pages/usage_guide/configuration-environment-…
fc4b3dc 
…overrides.adoc

Co-authored-by: Nick <[email protected]>
@fhennig @NickLarsenNZ
Update docs/modules/nifi/pages/usage_guide/custom_processors.adoc
05437d1 
Co-authored-by: Nick <[email protected]>
@fhennig @NickLarsenNZ
Update docs/modules/nifi/pages/usage_guide/custom_processors.adoc
25845fe 
Co-authored-by: Nick <[email protected]>
@fhennig @NickLarsenNZ
Update docs/modules/nifi/pages/usage_guide/configuration-environment-…
8e8b71b 
…overrides.adoc

Co-authored-by: Nick <[email protected]>
@fhennig @NickLarsenNZ
Update docs/modules/nifi/pages/usage_guide/custom_processors.adoc
12e8e73 
Co-authored-by: Nick <[email protected]>
@fhennig @NickLarsenNZ
Update docs/modules/nifi/pages/usage_guide/external_ports.adoc
cbad64a 
Co-authored-by: Nick <[email protected]>
@fhennig
Update installation.adoc
921518f
@fhennig
Update installation.adoc
35da3e8
@fhennig fhennig requested a review from NickLarsenNZ June 11, 2024 07:39
@fhennig fhennig enabled auto-merge June 17, 2024 07:10
NickLarsenNZ
NickLarsenNZ approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhennig fhennig added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit c4c9026 Jun 17, 2024
32 checks passed
@fhennig fhennig deleted the docs-maintenance branch June 17, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techassi Techassi Techassi left review comments

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@fhennig fhennig

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fhennig @NickLarsenNZ @Techassi